-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Support tags or some other filtering mechanism #75
Comments
I am OK with moving forward with "tags" that seems pretty flexible. Currently we have little need for access controls. We try to be open by default :) |
First pass implemented in master (#83). Feedback / testing would be much appreciated :) |
@tomkralidis I tried an upgrade of my quite old GHC to test this out. I am now getting DB errors I think. Check out related issue (#84). |
I also upgraded. Found no issues upgrading, using an existing
This created the new tables In the GUI, what worked:
What did not work:
A good start! |
To add: |
As for clicking on a tag showing all Resources, I think https://github.com/geopython/GeoHealthCheck/blob/master/GeoHealthCheck/views.py#L65
Returns all Resources, so this query may need adaptation. |
Suggestion: on https://github.com/geopython/GeoHealthCheck/blob/master/GeoHealthCheck/models.py#L73
At least in PostgreSQL this makes the table manageable in tools like |
Thanks for the feedback! Added the following fixes:
Todo:
|
Yes I can edit (add, remove) tags, even for existing Resources that had no tags. Two enhancements proposed:
|
@justb4 thanks for the feedback. I've moved the Edit, Cancel, Save buttons into their own row in the Resource page. Where should the tags input field be wider? On the resource info page or the add resource page? Or both (changes welcome)? |
@tomkralidis ok, good for the buttons, the tags input field is ok: only 2 enhancements directly seen:
|
@tomkralidis working reviving/expanding the tests in
Results in this:
|
Thanks @justb4; fixed. master branch should now address the tagging functionality (suggestions, counts, editing, etc.). If someone can test that would be great. |
Tested, handling much smoother with
Last error is hard to reproduce, several times seen. First the |
Thanks @justb4. first issue fixed, I cannot reproduce the second issue. |
I'll look into second, after merging master into https://github.com/justb4/GeoHealthCheck/tree/plugins_82. As the Edit-part of |
I tried to do an in-place upgrade to the latest version to include this functionality, and failed on the paver create step. In the database it created a tags table but not resource_tags, unfortunately I got no error, it just sat at the "Creating database objects" step for an hour. I got around this by creating a new database, editing config_site.py, running paver create and then restoring the old database over the top. So far so good, though I haven't done much tag creation yet... |
My guess: you are using PostGIS. I found some hanging issues exclusively with PG, never SQLite. Found that SQLAlchemy is in cases aggressively locking PG. Explicitly closing SQLA |
geopython#75 geopython#87 fix duplicate tag error (geopython#90)
Tag-support is done, now in maintenance mode. Locking issue also solved with code that went in via #82 (PR #93). See also demo on http://demo.geohealthcheck.org |
I'd like to be able to define tags for entries and then be able to filter by those tags. An entry might have more than one tag. Either tags could be free text, entered by the user when they create an entry, or defined by the admin and then picked when creating an entry. It should then be possible to filter by those tags in the left-hand menu or using the search box.
The text was updated successfully, but these errors were encountered: