Add cql-json support for ES #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francbartoli
added
enhancement
francbartoli
force-pushed
the
feature/cql-json-new
branch
from
6e13706
to
54db1f6
Compare
GeoSander
reviewed
Jul 12, 2021
francbartoli
force-pushed
the
feature/cql-json-new
branch
5 times, most recently
from
4819db1
to
a197c1d
Compare
tomkralidis
reviewed
Jul 21, 2021
There was a problem hiding this comment.
Looks great @francbartoli. My only questions are around use of nest_asyncio (does this have to be in pygeoapi/api.py or can we use in the starlette specific code?) and future-annotations.
@tomkralidis nest_asyncio fixes the |
francbartoli
force-pushed
the
feature/cql-json-new
branch
from
48fbacb
to
afd5b3a
Compare
Fix starlette event loop Fix starlette event loop Fix starlette event loop Fix starlette event loop Fix provider regression Make method public Make method public Move function to the helpers utility Add the CQL lifecycle for development Add CQL docs Fix flake8 Isolate import for starlette codepath
francbartoli
force-pushed
the
feature/cql-json-new
branch
from
afd5b3a
to
40e8bd3
Compare
|
Excellent work @francbartoli ! |
Merged
DManowitz
added a commit
to DManowitz/pygeoapi-feedstock
that referenced
this pull request
Jan 15, 2024
Although I was not able to find a minimum Python version referenced in setup.py, this comment (geopython/pygeoapi#723 (comment)) from a prior PR seems to indicate that `future-annotations` should be dropped as a requirement when Python 3.6 is no longer supported, so if they've dropped `future-annotations` as a dependency, I'm assuming that they're no longer supporting Python 3.6, either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replces #670 and adds an early implementation of CQL support for the Elasticsearch provider with the CQL-JSON dialect. It supports the following type of queries:
betweenpredicate queryandquery withbetweenandeqexpressionbbox