Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stable diffusion integration #1111

Merged
merged 10 commits into from
Sep 29, 2023
Merged

add stable diffusion integration #1111

merged 10 commits into from
Sep 29, 2023

Conversation

sudoboi
Copy link
Contributor

@sudoboi sudoboi commented Sep 13, 2023

No description provided.

github-actions[bot]
github-actions bot reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @sudoboi, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify that your PR is up-to-date with georgia-tech-db/eva master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.

@jarulraj
Copy link
Member

Need to add replicate in requirements.txt -- in the optional vision stuff?

@jarulraj
Copy link
Member

@sudoboi Nice job! Please add a notebook as well to illustrate the use-cases.

@xzdandy xzdandy added the AI Engines Features, Bugs, related to AI Engines label Sep 22, 2023
@xzdandy xzdandy added this to the v0.3.7 milestone Sep 22, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@aryan-rajoria
Copy link
Collaborator

Please run the linter before merging, it is in the script/formatting/formater.py

@sudoboi sudoboi merged commit 551f066 into georgia-tech-db:staging Sep 29, 2023
Chitti-Ankith
Chitti-Ankith reviewed Sep 29, 2023
View reviewed changes
evadb/functions/function_bootstrap_queries.py
EvaDB_INSTALLATION_DIR
)

dalle_function_query = """CREATE FUNCTION IF NOT EXISTS StableDiffusion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to have the StableDiffusion name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chitti-Ankith dalle_function_query isn't included in the list of queries that are loaded by default. I just added the query in case we need to use it at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chitti-Ankith Nevermind, you were talking about the function name. You're right.

sudoboi added a commit that referenced this pull request Sep 29, 2023
@sudoboi
Revert "add stable diffusion integration (#1111)"
90db1b6 
This reverts commit 551f066.
@xzdandy
Copy link
Collaborator

xzdandy commented Sep 29, 2023 •
edited
Loading

This PR breaks the staging. Please take look.

Quick notice:

  1. Please change the notebook name and if notebook also does not work on circle ci, we can skip the it. You can do it in script/test/test.sh. Do let us know why it does not work.
  2. Add a documentation to the function under https://evadb.readthedocs.io/en/stable/source/reference/ai/index.html
  3. Both test/integration_tests/long/functions/test_dalle.py and test/integration_tests/long/functions/test_selfdiffusion.py look unit tests instead of long integration tests, which is fine. If so, move them to test/unit_tests.

You can either revert and fix those in the original PR or create a new PR to address these issues. Thanks.

@xzdandy xzdandy mentioned this pull request Sep 29, 2023
Merged
xzdandy added a commit that referenced this pull request Sep 29, 2023
@xzdandy @sudoboi
Revert "add stable diffusion integration" (#1238)
90ac532 
Reverts #1111 

This PR breaks the staging. I will work with @sudoboi to fix and improve
the issues we found.

Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
@xzdandy xzdandy mentioned this pull request Sep 30, 2023
Merged
xzdandy added a commit that referenced this pull request Oct 15, 2023
@xzdandy @sudoboi
Add stable diffusion integration (#1240)
bf02232 
Reopen the #1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
RichardZhangRZ pushed a commit to RichardZhangRZ/evadb that referenced this pull request Oct 23, 2023
@xzdandy @sudoboi @RichardZhangRZ
Add stable diffusion integration (georgia-tech-db#1240)
83d1176 
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
@xzdandy @sudoboi @a0x8o
Add stable diffusion integration (georgia-tech-db#1240)
2b924b7 
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
@xzdandy @sudoboi @a0x8o
Add stable diffusion integration (georgia-tech-db#1240)
8a8a90a 
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
@xzdandy @sudoboi @a0x8o
Add stable diffusion integration (georgia-tech-db#1240)
f9b931f 
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
@xzdandy @sudoboi @a0x8o
Add stable diffusion integration (georgia-tech-db#1240)
a561022 
Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <guyphysicist@gmail.com>
Co-authored-by: Abhijith S Raj <63101280+sudoboi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chitti-Ankith Chitti-Ankith Chitti-Ankith left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@aryan-rajoria aryan-rajoria aryan-rajoria approved these changes

Assignees

@sudoboi sudoboi

Labels
AI Engines Features, Bugs, related to AI Engines
Projects
EVA Public Roadmap ⚡🚀
Archived in project
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.
5 participants
@sudoboi @jarulraj @aryan-rajoria @xzdandy @Chitti-Ankith