-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dimensions from TEXT
and FLOAT
#1261
Conversation
TEXT
and FLOAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying the type specification. Please fix the unit test cases: test/unit_tests/parser/test_parser.py::ParserTests::test_create_table_statement
2c05237
to
bf98b5b
Compare
Thanks @xzdandy. Pushed a fix! |
Hi @americast, Looks good. I will add some documentation. |
Thanks @xzdandy. Do you think there is a need to include support for backward compatibility? |
That's a good point. We can check if the tree has a child in the parser, and still visits it, if it has and skip if it doesn't. Thanks for thinking about backward compatibility! |
Users can now create a table with just `FLOAT` without providing the dimensions. Earlier: ```sql CREATE TABLE ETTM1 ( date TEXT(30), hufl FLOAT(5,7), hull FLOAT(5,7), mufl FLOAT(5,7), mull FLOAT(5,7), lufl FLOAT(5,7), lull FLOAT(5,7), ot FLOAT(5,7)); ``` Now: ```sql CREATE TABLE ETTM1 ( date TEXT, hufl FLOAT, hull FLOAT, mufl FLOAT, mull FLOAT, lufl FLOAT, lull FLOAT, ot FLOAT); ``` Fixes georgia-tech-db#1260. --------- Co-authored-by: Andy Xu <xzdandy@gmail.com>
Users can now create a table with just `FLOAT` without providing the dimensions. Earlier: ```sql CREATE TABLE ETTM1 ( date TEXT(30), hufl FLOAT(5,7), hull FLOAT(5,7), mufl FLOAT(5,7), mull FLOAT(5,7), lufl FLOAT(5,7), lull FLOAT(5,7), ot FLOAT(5,7)); ``` Now: ```sql CREATE TABLE ETTM1 ( date TEXT, hufl FLOAT, hull FLOAT, mufl FLOAT, mull FLOAT, lufl FLOAT, lull FLOAT, ot FLOAT); ``` Fixes georgia-tech-db#1260. --------- Co-authored-by: Andy Xu <xzdandy@gmail.com>
Users can now create a table with just `FLOAT` without providing the dimensions. Earlier: ```sql CREATE TABLE ETTM1 ( date TEXT(30), hufl FLOAT(5,7), hull FLOAT(5,7), mufl FLOAT(5,7), mull FLOAT(5,7), lufl FLOAT(5,7), lull FLOAT(5,7), ot FLOAT(5,7)); ``` Now: ```sql CREATE TABLE ETTM1 ( date TEXT, hufl FLOAT, hull FLOAT, mufl FLOAT, mull FLOAT, lufl FLOAT, lull FLOAT, ot FLOAT); ``` Fixes georgia-tech-db#1260. --------- Co-authored-by: Andy Xu <xzdandy@gmail.com>
Users can now create a table with just `FLOAT` without providing the dimensions. Earlier: ```sql CREATE TABLE ETTM1 ( date TEXT(30), hufl FLOAT(5,7), hull FLOAT(5,7), mufl FLOAT(5,7), mull FLOAT(5,7), lufl FLOAT(5,7), lull FLOAT(5,7), ot FLOAT(5,7)); ``` Now: ```sql CREATE TABLE ETTM1 ( date TEXT, hufl FLOAT, hull FLOAT, mufl FLOAT, mull FLOAT, lufl FLOAT, lull FLOAT, ot FLOAT); ``` Fixes georgia-tech-db#1260. --------- Co-authored-by: Andy Xu <xzdandy@gmail.com>
Users can now create a table with just
FLOAT
without providing the dimensions.Earlier:
Now:
Fixes #1260.