Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dimensions from TEXT and FLOAT #1261

Merged
merged 8 commits into from
Oct 7, 2023
Merged

Remove dimensions from TEXT and FLOAT #1261

merged 8 commits into from
Oct 7, 2023

Conversation

americast
Copy link
Member

Users can now create a table with just FLOAT without providing the dimensions.

Earlier:

CREATE TABLE ETTM1 (
        date TEXT(30),
        hufl FLOAT(5,7),
        hull FLOAT(5,7),
        mufl FLOAT(5,7),
        mull FLOAT(5,7),
        lufl FLOAT(5,7),
        lull FLOAT(5,7),
        ot FLOAT(5,7));

Now:

CREATE TABLE ETTM1 (
        date TEXT,
        hufl FLOAT,
        hull FLOAT,
        mufl FLOAT,
        mull FLOAT,
        lufl FLOAT,
        lull FLOAT,
        ot FLOAT);

Fixes #1260.

@americast americast added the Feature Request ✨ New feature or request label Oct 6, 2023
@americast americast added this to the v0.3.8 milestone Oct 6, 2023
@americast americast self-assigned this Oct 6, 2023
@americast americast changed the title remove dimensions from text and float Remove dimensions from TEXT and FLOAT Oct 6, 2023
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the type specification. Please fix the unit test cases: test/unit_tests/parser/test_parser.py::ParserTests::test_create_table_statement

@americast
Copy link
Member Author

Thanks for simplifying the type specification. Please fix the unit test cases: test/unit_tests/parser/test_parser.py::ParserTests::test_create_table_statement

Thanks @xzdandy. Pushed a fix!

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 6, 2023

Hi @americast, Looks good. I will add some documentation.

@americast
Copy link
Member Author

Thanks @xzdandy. Do you think there is a need to include support for backward compatibility?

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 6, 2023

Thanks @xzdandy. Do you think there is a need to include support for backward compatibility?

That's a good point. We can check if the tree has a child in the parser, and still visits it, if it has and skip if it doesn't. Thanks for thinking about backward compatibility!

@xzdandy xzdandy merged commit aeb9a3b into staging Oct 7, 2023
7 checks passed
@xzdandy xzdandy deleted the nodimtextfloat branch October 7, 2023 07:07
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
Users can now create a table with just `FLOAT` without providing the
dimensions.

Earlier:
```sql
CREATE TABLE ETTM1 (
        date TEXT(30),
        hufl FLOAT(5,7),
        hull FLOAT(5,7),
        mufl FLOAT(5,7),
        mull FLOAT(5,7),
        lufl FLOAT(5,7),
        lull FLOAT(5,7),
        ot FLOAT(5,7));
```

Now:
```sql
CREATE TABLE ETTM1 (
        date TEXT,
        hufl FLOAT,
        hull FLOAT,
        mufl FLOAT,
        mull FLOAT,
        lufl FLOAT,
        lull FLOAT,
        ot FLOAT);
```

Fixes georgia-tech-db#1260.

---------

Co-authored-by: Andy Xu <xzdandy@gmail.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
Users can now create a table with just `FLOAT` without providing the
dimensions.

Earlier:
```sql
CREATE TABLE ETTM1 (
        date TEXT(30),
        hufl FLOAT(5,7),
        hull FLOAT(5,7),
        mufl FLOAT(5,7),
        mull FLOAT(5,7),
        lufl FLOAT(5,7),
        lull FLOAT(5,7),
        ot FLOAT(5,7));
```

Now:
```sql
CREATE TABLE ETTM1 (
        date TEXT,
        hufl FLOAT,
        hull FLOAT,
        mufl FLOAT,
        mull FLOAT,
        lufl FLOAT,
        lull FLOAT,
        ot FLOAT);
```

Fixes georgia-tech-db#1260.

---------

Co-authored-by: Andy Xu <xzdandy@gmail.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
Users can now create a table with just `FLOAT` without providing the
dimensions.

Earlier:
```sql
CREATE TABLE ETTM1 (
        date TEXT(30),
        hufl FLOAT(5,7),
        hull FLOAT(5,7),
        mufl FLOAT(5,7),
        mull FLOAT(5,7),
        lufl FLOAT(5,7),
        lull FLOAT(5,7),
        ot FLOAT(5,7));
```

Now:
```sql
CREATE TABLE ETTM1 (
        date TEXT,
        hufl FLOAT,
        hull FLOAT,
        mufl FLOAT,
        mull FLOAT,
        lufl FLOAT,
        lull FLOAT,
        ot FLOAT);
```

Fixes georgia-tech-db#1260.

---------

Co-authored-by: Andy Xu <xzdandy@gmail.com>
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
Users can now create a table with just `FLOAT` without providing the
dimensions.

Earlier:
```sql
CREATE TABLE ETTM1 (
        date TEXT(30),
        hufl FLOAT(5,7),
        hull FLOAT(5,7),
        mufl FLOAT(5,7),
        mull FLOAT(5,7),
        lufl FLOAT(5,7),
        lull FLOAT(5,7),
        ot FLOAT(5,7));
```

Now:
```sql
CREATE TABLE ETTM1 (
        date TEXT,
        hufl FLOAT,
        hull FLOAT,
        mufl FLOAT,
        mull FLOAT,
        lufl FLOAT,
        lull FLOAT,
        ot FLOAT);
```

Fixes georgia-tech-db#1260.

---------

Co-authored-by: Andy Xu <xzdandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

TEXT and FLOAT requires dimensions compulsorily.
2 participants