Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds JSON/Py file loaders #1311

Closed
wants to merge 4 commits into from
Closed

adds JSON/Py file loaders #1311

wants to merge 4 commits into from

Conversation

Omanshb
Copy link

@Omanshb Omanshb commented Oct 23, 2023

The following change adds JSON and Python Script File loaders to EvaDB.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @Omanshb, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify that your PR is up-to-date with georgia-tech-db/eva master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 24, 2023

Hi @Omanshb, thanks for add json and py file support. Is PR ready? Could you add some testcases and documentations? Thanks!

@Omanshb Omanshb closed this Oct 24, 2023
@Omanshb Omanshb reopened this Oct 24, 2023
@hershd23
Copy link
Contributor

Is this up for review?

@jarulraj
Copy link
Member

jarulraj commented Nov 6, 2023

FAILED test/integration_tests/long/test_model_train.py::ModelTrainTests::test_xgboost_regression - evadb.executor.executor_utils.ExecutorError: 'EvaDBDatabase' object has no attribute 'config' -- @jineetd any idea?

@Omanshb Omanshb closed this Nov 6, 2023
@Omanshb Omanshb deleted the json_py_load_addition branch November 6, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants