Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cockroach-db intergration support for EvaDB #1423

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Adding cockroach-db intergration support for EvaDB #1423

wants to merge 2 commits into from

Conversation

VrtanoskiAndrej
Copy link

Implementing the CockroachDB Handler, adding unit tests and adding documentation support for CockroachDB.

americast
americast requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@americast americast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may use the in-built linter to format the code with bash script/test/test.sh -m LINTER.

docs/source/reference/databases/cockroachdb.rst
@@ -0,0 +1,36 @@
CockroachDB
==========
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs build is failing in this line. Maybe we need a few more =?

americast
americast requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@americast americast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you would have to add cockroachdb installation procedure in setup.py for the unit test to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@americast americast americast requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VrtanoskiAndrej @americast