Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-built bindings for GDAL 3.6 #351

Closed
ttencate opened this issue Dec 15, 2022 · 1 comment · Fixed by #352
Closed

Add pre-built bindings for GDAL 3.6 #351

ttencate opened this issue Dec 15, 2022 · 1 comment · Fixed by #352

Comments

@ttencate
Copy link
Contributor

ttencate commented Dec 15, 2022 •
edited
Loading 

  thread 'main' panicked at 'No pre-built bindings available for GDAL version 3.6. Use `--features bindgen` to generate your own bindings.', /home/thomas/.cargo/registry/src/github.com-1ecc6299db9ec823/gdal-sys-0.7.0/build.rs:248:17

Yep, these aren't currently included.

It works if I put this in my Cargo.toml:

gdal-sys = { version = '0.8.0', features = ['bindgen'] }

I tried to create a PR for prebuilt bindings for 3.6 by copying the bindings.rs file from somewhere inside the target/ directory, but it seems to be missing docstrings that gdal_3.5.rs has. If someone would tell me (or better yet, document!) how to generate these properly, I'll be happy to finish the PR.
@lnicola
Copy link
Member

lnicola commented Dec 15, 2022 •
edited
Loading

Might be #55 (comment), see also https://docs.rs/bindgen/latest/bindgen/struct.Builder.html#method.generate_comments.

ttencate added a commit to ttencate/gdal that referenced this issue Dec 15, 2022
@ttencate
Add prebuilt bindings for GDAL 3.6 and document how to do it
686273e 
Fixes georust#351
@ttencate ttencate mentioned this issue Dec 15, 2022
Merged
2 tasks
ttencate added a commit to ttencate/gdal that referenced this issue Dec 15, 2022
@ttencate
Add prebuilt bindings for GDAL 3.6 and document how to do it
30d02c3 
Fixes georust#351
bors bot added a commit that referenced this issue Dec 15, 2022
@bors @ttencate
Merge #352
6e07805 
352: Add prebuilt bindings for GDAL 3.6 and document how to do it r=lnicola a=ttencate

Fixes #351

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---



Co-authored-by: Thomas ten Cate <ttencate@gmail.com>
@bors bors bot closed this as completed in 1f390ea Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add prebuilt bindings for GDAL 3.6 and document how to do it ttencate/gdal
2 participants
@ttencate @lnicola