Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature::field returns Result<Option<FieldValue>> #134

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Feature::field returns Result<Option<FieldValue>> #134

merged 2 commits into from
Jan 22, 2021

Commits on Jan 22, 2021

  1. Feature::field returns Result<Option<FieldValue>> 

    Currently, Feature::field returns Result<FieldValue>, but fields can be
null. When this is the case, the default value for the FieldValue
variant is returned. This makes it difficult to distinguish e.g. a
legitimate Integer 0 value from the absence of a value.

Instead, return a Result<Option<FieldValue>> so that null fields can be
distinguished from default values.
    @dead10ck
    dead10ck committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    14dae81 View commit details
    Browse the repository at this point in the history

  2. Add breaking change notice to CHANGES.md

    @dead10ck
    dead10ck committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    cbcf90e View commit details
    Browse the repository at this point in the history