Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RasterBand's colour interpretation #144

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Add RasterBand's colour interpretation #144

merged 5 commits into from
Feb 25, 2021

Conversation

shuternay
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

This PR adds methods for reading and setting RasterBand's colour interpretation. It also adds methods for getting interpretation value name and getting interpretation value by name.

P.S. I'm not sure how to achieve this, but shouldn't mutable borrow of RasterBand require mutable borrow of it's Dataset?

Copy link
Member

@jdroenner jdroenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at the exports / imports and remove the "get_" prefix. Also please resolve the merge conflicts.

src/raster/mod.rs Outdated Show resolved Hide resolved
src/raster/rasterband.rs Outdated Show resolved Hide resolved
src/raster/tests.rs Outdated Show resolved Hide resolved
@shuternay
Copy link
Contributor Author

I've added an enum for color interpretations (should resolve problems with free methods and imports) and resolved merge conflicts

@jdroenner jdroenner merged commit 838a685 into georust:master Feb 25, 2021
@shuternay shuternay deleted the raster_color_interp branch February 25, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants