Metadata iterator #344
Merged
Metadata iterator #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
force-pushed
the
feature/md-iter
branch
from
4b4eab6
to
5b33409
Compare
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
metasim
commented
Nov 30, 2022
lnicola
reviewed
Dec 2, 2022
lnicola
reviewed
Dec 2, 2022
lnicola
reviewed
Dec 2, 2022
lnicola
reviewed
Dec 2, 2022
lnicola
reviewed
Dec 2, 2022
* master: Nit picking :) Feature::geometry now returns an Option<&Geometry> and will not panic when the feature does not have geometry Removed use of custom cargo env var. Clippy rustfmt Handling cases where feature may not have any geometry at all Replaced `fixture!` macro with a simple function. Disable chrono default features Reverted bindgen-caused warning suppressions. Update CHANGES.md Update bindgen requirement from 0.61 to 0.63 Consolidated `fixture!` implementation and enabled usage anywhere in module structure. Refined chrono version range. Hold back chrono version until deprecations can be addressed. Changelog. Fixes leakage of GDALDataType::Type in RasterBand.
metasim
force-pushed
the
feature/md-iter
branch
from
b8b99ee
to
ba141f9
Compare
|
@lnicola Thanks for all the constructive feedback. I think it's all incorporated. |
lnicola
approved these changes
Dec 6, 2022
|
LGTM, but I suggest waiting a couple more days in case someone else wants to take a look. |
|
bors r=lnicola |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Provides an iterator over
Metadata.Also fleshes out other documentation around
Metadata.