Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change COORD_PRECISION from f64 to f32. #39

Closed
frewsxcv opened this issue Jul 17, 2016 · 1 comment
Closed

Change COORD_PRECISION from f64 to f32. #39

frewsxcv opened this issue Jul 17, 2016 · 1 comment
Assignees
@Kerollmops
Labels
good first issue

Comments

@frewsxcv
Copy link
Member

https://github.com/georust/rust-geo/blob/e23eaa69749c1279d7e41cf38e6335fcec324b23/src/types.rs#L7

f64 is probably overkill for a value of 1e-1.
@frewsxcv
Copy link
Member Author

@Kerosene2000 Were you interested in doing this? Otherwise I can take care of it. Would be nice to get this in before the upcoming 0.2 release since it's a breaking change.

@Kerollmops Kerollmops mentioned this issue Jul 17, 2016
Merged
@Kerollmops Kerollmops self-assigned this Jul 17, 2016
nyurik pushed a commit to nyurik/geo that referenced this issue Mar 19, 2022
@bors @osialr
Merge georust#39
f326aed 
39: Don't panic on invalid number r=frewsxcv a=osialr

In Wkt::from_str, invalid numbers are causing a panic but other kinds of input return an Err.



Co-authored-by: Ryan Osial <ryan.osial@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerollmops Kerollmops

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frewsxcv @Kerollmops