Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #1084: panics on haversine_closest_point #1119

Merged
merged 2 commits into from
Nov 23, 2023
Merged

issue #1084: panics on haversine_closest_point #1119

merged 2 commits into from
Nov 23, 2023

Conversation

fegies
Copy link
Contributor

@fegies fegies commented Nov 21, 2023 •
edited
Loading

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Issue #1084:

  • added failing test case reproducing problem
  • Fixed the issue

@fegies fegies force-pushed the haversine_closest_point_panic_fix branch from 71603ee to 9b86ce9 Compare November 21, 2023 19:58
@fegies fegies marked this pull request as ready for review November 21, 2023 19:59
@fegies fegies mentioned this pull request Nov 21, 2023
Closed
urschrei
urschrei approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@urschrei urschrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, my one minor comment notwithstanding.

geo/src/algorithm/haversine_closest_point.rs Outdated Show resolved Hide resolved
@urschrei
Copy link
Member

(The Clippy complaint is also trivial)

@fegies
Fix georust#1084:
82f9784 
- Add a failing test case demonstrating georust#1084
- Fix georust#1084
@fegies fegies force-pushed the haversine_closest_point_panic_fix branch from 9b86ce9 to 82f9784 Compare November 22, 2023 08:33
@fegies
Copy link
Contributor Author

fegies commented Nov 22, 2023 •
edited
Loading

Removed the extra comment and made clippy happy.

@urschrei
Copy link
Member

Thanks! And if you could also add an entry to geo/CHANGES.md (apologies, I should have asked yesterday)

@fegies
Copy link
Contributor Author

fegies commented Nov 22, 2023 •
edited
Loading

Thanks! And if you could also add an entry to geo/CHANGES.md (apologies, I should have asked yesterday)

To a patch subversion? 0.27.1?
Or add the Unreleased Header?

@urschrei
Copy link
Member

Thanks! And if you could also add an entry to geo/CHANGES.md (apologies, I should have asked yesterday)

To a patch subversion? 0.27.1?

Or add the Unreleased Header?

Just under Unreleased please!

@fegies
Copy link
Contributor Author

fegies commented Nov 22, 2023

Done.

@urschrei
Copy link
Member

Thanks, I'll leave it open for another few hours in case anyone else wants to weigh in.

@urschrei urschrei added this pull request to the merge queue Nov 23, 2023
Merged via the queue into georust:main with commit 7cb7d0f Nov 23, 2023
15 checks passed
@ianthetechie ianthetechie mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urschrei urschrei urschrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fegies @urschrei