Extract test fixtures into WKT files #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
force-pushed
the
extract-test-fixtures
branch
5 times, most recently
from
577278e
to
ba68d10
Compare
lnicola
force-pushed
the
extract-test-fixtures
branch
from
ba68d10
to
3bfb2d4
Compare
lnicola
commented
Dec 25, 2021
|
|
||
| bencher.iter(|| { | ||
| criterion::black_box(criterion::black_box(&polygon).extremes()); | ||
| }); | ||
| }); | ||
|
|
||
| c.bench_function("extremes f64", |bencher| { | ||
| let points = include!("../src/algorithm/test_fixtures/norway_main.rs"); | ||
| let polygon = Polygon::new(LineString::<f32>::from(points), vec![]); |
| @@ -39,8 +35,7 @@ fn criterion_benchmark(c: &mut Criterion) { | |||
| }); | |||
|
|
|||
| c.bench_function("simplify vwp f64", |bencher| { | |||
| let points = include!("../src/algorithm/test_fixtures/louisiana.rs"); | |||
| let ls: LineString<f32> = points.into(); | |||
| .map(|e| Coordinate { x: e.0, y: e.1 }) | ||
| .collect(); | ||
| let res = quick_hull(&mut v); | ||
| assert!(res.is_strictly_ccw_convex()); |
|
r? @urschrei |
|
And me! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fixes #566
Some notes:
#[cfg(bench)]); it haspublish = falseto prevent accidental publishingextremes f64andsimplify vwp f64benches were testing anf32implementationrust-analyzerused to balk on the largerinclude!s, it feels much better now