Improvements #42
Merged
Improvements #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-de
reviewed
Apr 11, 2019
|
Updated. |
antoine-de
approved these changes
Apr 11, 2019
| @@ -96,7 +97,7 @@ impl<'a> CoordSeq<'a> { | |||
| if !data.iter().skip(1).all(|x| x.len() == dims) { | |||
| return Err(Error::GenericError("All vec entries must have the same size!".to_owned())); | |||
| } | |||
| match match GContextHandle::init() { | |||
| match GContextHandle::init() { | |||
There was a problem hiding this comment.
can't you put and_then on the first one too ?
GContextHandle::init().and_then( unsafe {...}).and_then(|coord|...
There was a problem hiding this comment.
You're asking a bit too much of me! I love matches. :'(
|
I'll rewrote all of that with `map_err` and `?` personally.
Le 11 avril 2019 16:49:13 CEST, Guillaume Gomez <notifications@github.com> a écrit :
…GuillaumeGomez commented on this pull request.
> @@ -96,7 +97,7 @@ impl<'a> CoordSeq<'a> {
if !data.iter().skip(1).all(|x| x.len() == dims) {
return Err(Error::GenericError("All vec entries must have the same
size!".to_owned()));
}
- match match GContextHandle::init() {
+ match GContextHandle::init() {
You're asking a bit too much of me! I love `match`es. :'(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#42 (comment)
--
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
|
|
This PR is big enough as is. Next step: splitting FFI part from this crate. @TeXitoi: I'm not a big fan of that but if you want it, please open a PR. :) |
|
@GuillaumeGomez I havent been able to follow your PRs very closely but thank you for all the work in improving that library ! |
|
I dont really care that's just style. |
|
@mthh No problem and you're welcome! ;) |
|
@TeXitoi Style is important so feel free to apply yours anytime. :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.