Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to take a stab at this to resolve #37 but ran into a few issues/questions:
process_geoarrow_feature_chunk
in the geoarrow mod, because the parquet reader's result is automatically geoarrow (of the wkb variant). In theory we could implementGeozeroDatasource
for geoarrow directly as well to convert from an arrow table, but that might be less useful.GeozeroGeometry
in addition toGeozeroDatasource
, becauseGeozeroGeometry
'sprocess_geom
only provides a non-mutable reader, and the parquetFileReader
needed a mutable reference. Or maybe I'm missing something there.Array
trait objects, so we need to do downcasting to get values out. Is it possible to do that downcasting outside of the loop so that we don't have to downcast on every iteration?