Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GeoParquet reader #80

Closed
wants to merge 4 commits into from
Closed

Conversation

kylebarron
Copy link
Member

I started to take a stab at this to resolve #37 but ran into a few issues/questions:

  • I put process_geoarrow_feature_chunk in the geoarrow mod, because the parquet reader's result is automatically geoarrow (of the wkb variant). In theory we could implement GeozeroDatasource for geoarrow directly as well to convert from an arrow table, but that might be less useful.
  • It seemed not possible to write an impl for GeozeroGeometry in addition to GeozeroDatasource, because GeozeroGeometry's process_geom only provides a non-mutable reader, and the parquet FileReader needed a mutable reference. Or maybe I'm missing something there.
  • I'm not sure the best way of doing arrow -> geozero feature objects. Arrow2's "chunk" object is a vec of Array trait objects, so we need to do downcasting to get values out. Is it possible to do that downcasting outside of the loop so that we don't have to downcast on every iteration?
  • I assume geozero has a record-only API? I.e. I can't process all the data column by column, it needs to be row-by-row?

@pka
Copy link
Member

pka commented Dec 20, 2022

Rebasing should solve the failed CI test.

@nyurik
Copy link
Member

nyurik commented Apr 9, 2023

I did the merge, but i have no domain knowledge about this PR

@nyurik
Copy link
Member

nyurik commented Apr 9, 2023

@kylebarron & @pka please update on this PR's path, if it needs more changes, or should be closed or merged

@kylebarron
Copy link
Member Author

Closing this because it's been (mostly) implemented in https://github.com/geoarrow/geoarrow-rs, with transitive bindings into geozero.

@kylebarron kylebarron closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geoparquet format reader
3 participants