Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for route tag #26

Merged
merged 4 commits into from
May 2, 2020
Merged

Add support for route tag #26

merged 4 commits into from
May 2, 2020

Conversation

acco32
Copy link

@acco32 acco32 commented Apr 22, 2020

No description provided.

michaelkirk
michaelkirk reviewed Apr 24, 2020
View reviewed changes
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks reasonable to me, but I'm not familiar with this project, just a drive by review.

@acco32
Copy link
Author

acco32 commented Apr 25, 2020

Thanks @michaelkirk

frewsxcv
frewsxcv approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@frewsxcv frewsxcv merged commit 4fcc7a1 into georust:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkirk michaelkirk michaelkirk left review comments

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acco32 @michaelkirk @frewsxcv