Fix array conversion #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bors try |
tryBuild succeeded: |
|
bors try Interesting! Let's gather some stats here. |
|
If your run passes, I'm gonna contrive a doctest with different CRS and coordinates. I have my doubts about the validity of the old Stereo70 conversion values, but there's less value in a doctest that just reproduces an existing known-good test. |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
|
These are CRS and coordinate values from https://geodesy.noaa.gov/NCAT/. WDYT? |
michaelkirk
approved these changes
Jan 6, 2021
| /// assert_approx_eq!(v[0].y(), 500027.77901023754f64); | ||
| /// let from = "EPSG:2230"; | ||
| /// let to = "EPSG:26946"; | ||
| /// let ft_to_m = Proj::new_known_crs(&from, &to, None).unwrap(); |
There was a problem hiding this comment.
Nice to have a more focused example in the docs. I tremble when faced with raw "proj script".
- better variable name - remove test loop that appeared without explanation
|
bors r=michaelkirk |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My suspicion is that creating the raw pointer in the function call was causing it to be dropped prematurely, resulting in garbage data. See here for an analogous issue when getting a
CStringpointer. We avoid this by explicitly creating the pointer before the call. In addition, the doctest has been updated with a less complex example that doesn't use a proj string.