Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo-all-features to test all combinations of features #62

Closed
wants to merge 3 commits into from

Conversation

frewsxcv
Copy link
Member

WIP

@frewsxcv frewsxcv closed this Feb 22, 2021
@frewsxcv frewsxcv deleted the frewsxcv-all-features branch February 22, 2021 23:24
@michaelkirk
Copy link
Member

I really like cargo-test-all-features...

e.g. it caught this bug georust/wkt#59 (comment)

It's currently pretty slow for the proj crate, but maybe that's OK. It'd be a real milestone if enough development was happening that CI became the bottleneck. 🙃

@frewsxcv frewsxcv restored the frewsxcv-all-features branch February 22, 2021 23:37
@frewsxcv frewsxcv reopened this Feb 22, 2021
@frewsxcv
Copy link
Member Author

@michaelkirk Well this PR is basically ready to go. I just wasn't sure about removing the _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC test 🤷🏻

@michaelkirk
Copy link
Member

I just wasn't sure about removing the _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC test 🤷🏻

Oh right I forgot about that... I do like being able to test that we're building / not building from source.

I don't see how to reconcile that with cargo-test-all-features...

We could add another mostly-redundant cargo test-all-features job, just to make sure the compiler doesn't explode under any feature combinations, but I'm not sure if it's worth it.

sorry for the 🧇 🧇 🧇 🧇 🧇 🧇 🧇 🧇

@frewsxcv frewsxcv closed this Feb 23, 2021
@frewsxcv frewsxcv deleted the frewsxcv-all-features branch February 23, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants