Use eager leaf envelope computation

[urschrei]

• I agree to follow the project's code of conduct.
• I added an entry to rstar/CHANGELOG.md if knowledge of this change could be valuable to users.

---

[adamreichold]

RTree::bulk_load should also have Vec<T> replaced by I: IntoIterator<Item = T> to avoid needlessly allocating a Vec which will be deconstructed anyway.

[urschrei]

Done, although it's now causing a test to stop compiling due to a tricky type inference failure. See 2dce546

[adamreichold]

Indeed, the same .iter().cloned() change which helps the benchmark will also fix the test though

diff --git a/rstar/src/algorithm/bulk_load/bulk_load_sequential.rs b/rstar/src/algorithm/bulk_load/bulk_load_sequential.rs
index a2ff07c..eae997a 100644
--- a/rstar/src/algorithm/bulk_load/bulk_load_sequential.rs
+++ b/rstar/src/algorithm/bulk_load/bulk_load_sequential.rs
@@ -154,7 +154,7 @@ mod test {
         P: RTreeObject + Send + Sync + Eq + Clone + Debug + Hash + 'static,
         P::Envelope: Send + Sync,
     {
-        let tree = RTree::bulk_load(points.into());
+        let tree = RTree::bulk_load(points.iter().cloned());
         let set1: HashSet<_> = tree.iter().collect();
         let set2: HashSet<_> = points.iter().collect();
         assert_eq!(set1, set2);

(The .into() call was basically .to_vec() which would also work, but allocate the unnecessary temporary Vec.)

[urschrei]

Great, fixed.

[urschrei]

Test failures are spurious: due my disabling a test which can't run due to a type inference issue.

[adamreichold]

Closing since we went for #118 instead.