Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch 2 science updates: aerosol distribution fixes #28

Merged

Conversation

jimmielin
Copy link

@jimmielin jimmielin commented Nov 7, 2023

This will change SO4 to be deposited using Neu (as gas) instead of as aerosol as there's some mass conservation issues when mapping back from MAM4 to the GEOS-Chem bulk tracers. Thus the gas dry/wetdep list now includes the GEOS-Chem bulk SO4 tracer.

It is ok to keep the so4_aX tracers in aer_dry/wetdep_list since the changes from within MAM will be ignored by chemistry.F90.

The proper way to deal with the aerosols is just to have a MAM implementation in GEOS-Chem...

Todo

  • Need to change dep_data_file to dep_data_file_geoschem_c230602.nc. This file also needs to be moved to /glade/p/cesmdata/cseg/inputdata/atm/cam/chem/geoschem/dvel. This file is currently at /glade/work/hplin/Shared.

@jimmielin jimmielin marked this pull request as draft November 7, 2023 16:09
This will not affect existing simulations because SO4 would be overwritten with MAM4 aerosols anyway.
But if MAM4 aerosols will not overwrite GEOS-Chem SO4 in proposed changes, then SO4 must be scavenged (similarly to gas) as a bulk tracer by Neu.
@jimmielin jimmielin changed the title [DRAFT] Batch 2 science updates: aerosol distribution fixes Batch 2 science updates: aerosol distribution fixes Feb 29, 2024
@jimmielin jimmielin marked this pull request as ready for review March 18, 2024 17:23
@jimmielin
Copy link
Author

Hi @lizziel ,

I just merged up to latest version of CAM and lifted the draft flag. Please feel free to review the code. Thanks!

@lizziel lizziel changed the base branch from CESM-GC_rebased_on_cam6_0_034 to feature/geoschem_14.3 April 1, 2024 16:17
@lizziel
Copy link

lizziel commented Apr 1, 2024

I approved this and plan to bring it into the feature/geoschem_14.3 branch. I will create a new deposition netcdf file for this update since it needs to be incorporated into the file I prepared for 14.3.

@lizziel lizziel merged commit b31993b into geoschem:feature/geoschem_14.3 Apr 1, 2024
@lizziel
Copy link

lizziel commented Apr 1, 2024

Actually I do not need to update the deposition file since SO4 is already included in the one I use for 14.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants