Fix bug in advection when using raw GMAO meteorology files #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR fixes a bug in dry pressures passed to advection when using raw GMAO meteorology files. The moisture used for the conversion from 2D surface moist pressure to 3D level edge dry pressure needs to be vertically flipped when using raw GMAO input files.
This was a bug introduced in 14.0 when reverting to using dry air pressure in advection. The prior implementation of using dry air pressure in advection (13.3 and prior) did not yet have the 13.4 update to run with raw GMAO files. GCHP benchmarking uses only processed meteorology files which are vertically flipped relative to the raw files and therefore this bug went under the radar until now.
Expected changes
This is a no diff update for GCHP benchmarking. See the GitHub issue linked below for expected differences in runs using raw GMAO meteorology input files.
Reference(s)
None
Related Github Issue(s)
#386