Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in advection when using raw GMAO meteorology files #392

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Mar 13, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR fixes a bug in dry pressures passed to advection when using raw GMAO meteorology files. The moisture used for the conversion from 2D surface moist pressure to 3D level edge dry pressure needs to be vertically flipped when using raw GMAO input files.

This was a bug introduced in 14.0 when reverting to using dry air pressure in advection. The prior implementation of using dry air pressure in advection (13.3 and prior) did not yet have the 13.4 update to run with raw GMAO files. GCHP benchmarking uses only processed meteorology files which are vertically flipped relative to the raw files and therefore this bug went under the radar until now.

Expected changes

This is a no diff update for GCHP benchmarking. See the GitHub issue linked below for expected differences in runs using raw GMAO meteorology input files.

Reference(s)

None

Related Github Issue(s)

#386

…rology

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel added the bugfix label Mar 13, 2024
@lizziel lizziel added this to the 14.3.1 milestone Mar 13, 2024
@lizziel lizziel requested a review from yantosca March 13, 2024 20:27
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel! Good to merge!

@yantosca yantosca self-assigned this Mar 13, 2024
@yantosca
Copy link
Contributor

Integration tests are running

@yantosca
Copy link
Contributor

All GCHP integration tests passed

==============================================================================
GCHP: Execution Test Results

GCHP      #23444e1 Fix bug in edge pressures used in advection when using raw GMAO meteorology
GEOS-Chem #67220bb52 Merge PR #2178 (Rename "native" to "raw" in GCHP rundir scripts)
HEMCO     #22de25e Merge PR #263 (Restrict volcano clim prints to root thread)

Number of execution tests: 6

Submitted as SLURM job: 23355170
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all GCHP integration tests were zero-diff w/r/t 14.3.0.

@yantosca yantosca merged commit 9100a1d into dev/no-diff-to-benchmark Mar 14, 2024
1 check passed
@yantosca yantosca deleted the bugfix/gmao_raw_met branch March 14, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants