Fix nvhpc compiler error in CESM due to line length exceeded #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make compile compatible with the nvhpc compiler. This was reported downstream from ESCOMP/CAM#871 and at HEMCO#233. Reported-by: Jian Sun @sjsprecious Signed-off-by: Haipeng Lin <hplin@seas.harvard.edu>
lizziel
changed the title
lizziel
added
category: Interface to External Model
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
bugfix/line_length_too_long_for_nvhpc_compiler
branch
from
485d430
to
068e067
Compare
yantosca
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update makes HEMCO compatible with the nvhpc compiler. The bug that prevents compiling with nvhpc was reported downstream from ESCOMP/CAM#871 and at HEMCO#233. The problem was originally reported-by: Jian Sun @sjsprecious. A bug fix will be included in HEMCO 3.7.1 (see @jimmielin's #234) but we also need it in a 3.6.x version for use with GEOS-Chem 14.1.1 in CESM.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
Use continuation marks for GC_72_EDGE_SIGMA variable specific to MODEL_WRF and MODEL_CESM.
This will make it compatible with Fortran spec, as nvhpc compiler will throw an error about this line of code.
Expected changes
Zero diff, pure reformatting of code lines that are used only in WRF and CESM.
Reference(s)
N/A
Related Github Issue(s) and PRs