Populate mid-run checkpoints with non-species data every timeset #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run/GCClassic/README - removed run/GCClassic/README.md - Added w/ updated links for 14.0.0 Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
We have now added the link to GEOS-Chem Supporting Guidelines. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.CH4 run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.tagCH4 - Set the "analytical_inversion/activate:true" flag to false. The analyical inversion is only used for the Integrated Methane Inversion (aka IMI). The IMI will toggle this to true. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
…mestep Previously non-species data was only updated in the internal state at the end of the run. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
added
category: Bug
msulprizio
approved these changes
Oct 18, 2022
msulprizio
deleted the
bugfix/set_all_intstate_ptrs_for_midrun_checkpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update in this PR fixes a GCHP bug in which non-species entries in mid-run restart files (aka checkpoint files) were incorrect. All internal state data is now updated every timestep, with the except of area which is only updated in the first timestep since it is time-invariant.
This update will have no impact on GCHP 1-month benchmarks or end-of-run restart files. It will correct a problem in 1-year GCHP benchmarks which used mid-run checkpoint files to retrieve area for generating mass tables. It will also correct error introduced when restarting a GCHP simulation from a previously generated mid-run checkpoint file to continue a series of runs. This would happen if, for example, a run crashed mid-way through the configured run duration due to a compute cluster issue rather than a model issue.