Add fix for CH4 analytical inversions to convert state vector values read from file to nearest integer #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read from file to nearest integer In global_ch4_mod.F90, the state vector elements read from a netCDF file via HEMCO are defined as REAL(fp). To determine if an emissions perturbation needs to be applied, that value is compared to Input_Opt%StateVectorElement which is an INTEGER read from geoschem_config.yml. Roundoff error in the STATE_VECTOR array occasionally led to elements not correctly being identified. The solution is to round the STATE_VECTOR value to the nearest integer before comparing to Input_Opt%StateVectorElement. See also geoschem/integrated_methane_inversion#167 Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
added
the
topic: Analytical Inversions
yantosca
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
This looks good to merge @msulprizio! I'll test it for inclusion into 14.2.1.
|
After merging locally atop PR #1974, all GEOS-Chem Classic integration tests passed (except for TOMAS, which is a known issue). ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #d693e88 GEOS-Chem submod update: Merge PR #1974 (Bug fixes in ExtData.rc templates)
GEOS-Chem #6fa3f574d Merge PR #1976 (Add fix for CH4 state vector for inversions)
HEMCO #daf54d0 Merge PR #235 (Bug fix for vertical regridding)
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 3970365
==============================================================================
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0Furthermore, all integration tests were zero-diff w/r/t the prior integration test (PR#1974) except for the usual suspects (which have known issues that will be fixed later): Checking gc_4x5_merra2_fullchem_RRTMG
-> 1 difference found in OutputDir
* GCC_r28/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4
GCC_r29/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4
-> No differences in Restarts
Checking gc_4x5_merra2_fullchem_RRTMG
-> 1 difference found in OutputDir
* GCC_r28/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4
GCC_r29/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4
-> No differences in Restarts |
|
After merging locally atop PR #1974, all GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCClassic #dc45a27 GEOS-Chem submod update: Merge PR #1974 (Bug fixes in ExtData.rc templates)
GEOS-Chem #6fa3f574d Merge PR #1976 (Add fix for CH4 state vector for inversions)
HEMCO #daf54d0 Merge PR #235 (Bug fix for vertical regridding)
Number of execution tests: 5
Submitted as SLURM job: 3970381
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all integration tests were zero-diff w/r/t PR #1974. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
In global_ch4_mod.F90, the state vector elements read from a netCDF file via HEMCO are defined as REAL(fp). To determine if an emissions perturbation needs to be applied, that value is compared to Input_Opt%StateVectorElement which is an INTEGER read from geoschem_config.yml. Roundoff error in the STATE_VECTOR array occasionally led to elements not correctly being identified. The solution is to round the STATE_VECTOR value to the nearest integer before comparing to Input_Opt%StateVectorElement.
Related Github Issue(s)