Allow using existing copy of species DB for re-init of State_Chm. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update prevents calling Init_Species_Database multiple times within the same CPU, even if there are multiple State_Chms. This update also adds a counter, nChmState, to state_met_mod.F90. This counts the amount of chemistry state objects we have initialized, on this CPU. It prevents the deallocation of shared pointers in the ChmState object (right now, State_Chm%SpcData), until the last chemistry state is cleaned up, so we do not have dangling pointers. Signed-off-by: Haipeng Lin <linhaipeng@pku.edu.cn>
yantosca
added a commit
that referenced
this pull request
Oct 19, 2018
Added the following netCDF diagnostics as fields of State_Diag: (1) LossCH4byClinTrop (corresponds to ND19 #3) (2) LossCH4byOHinTrop (corresponds to ND19 #1) (3) LossCH4inStrat (corresponds to ND19 #2) Removed the ND58 diagnostic, because those fields are now archived to the HEMCO_diagnostics*.nc files directly. Also removed the ND60 bpch diagnostic (wetland fraction for CH4) because the CH4 simulation currently reads wetland emissions via HEMCO. The wetland emissions are now archived directly to the HEMCO_diagnostics*.nc files, so there is no need for the ND60 bpch diagnostic anymore. (NOTE: The ND60 implementation for TOMAS was left as-is.) Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added a commit
that referenced
this pull request
Jan 25, 2023
test/GCClassic/README.md test/GCHP/README.md - Added point #2 to instruct the user to run the Git commmand "git submodule update --init --recursive" to make sure that all submodules are checked otut to the proper place. - Updated points #3 & #4 to include the instruction to check out the proper branch if the GEOS-Chem/HEMCO submodules do not point to the proper commit. This is because very often we test branches that are updated in GEOS-Chem/HEMCO but not in the superprojects. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
1 task
msulprizio
pushed a commit
that referenced
this pull request
Jan 16, 2024
Limit internal state var TSTRAT_Adj to RRTMG simulations only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update prevents calling
Init_Species_Database(species_database_mod.F90) multiple times within the same CPU, even if there are multipleState_Chms to initialize. It checks whether there is already a species database and directly associate the newState_Chm%SpcDatato the existing copy.This update also adds a counter,
nChmState, tostate_met_mod.F90. This counts the amount of chemistry state objects we have initialized, on this CPU. This prevents the deallocation of pointers to shared data structures in theChmStateobject (right now, onlyState_Chm%SpcData), until the last chemistry state is cleaned up, so we do not have dangling pointers.I've tried my best to keep to the current coding style. Please let me know if there are any changes necessary.
Signed-off-by: Haipeng Lin linhaipeng@pku.edu.cn