-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geosci labs #111
Geosci labs #111
Conversation
…to geosci-labs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lheagy , trying to run this branch on mybinder, none of the seismic apps are working (error 404: page not found). Same for the EM_ThreeLoopModel
, and the EM_ResponseFunction
.
It might be just a naming problem (for example, it seems EM_ThreeLoopModel
got renamed FDEM_ThreeLoopModel
; for seismic the path is now seismic/....ipynb
and not anymore seis/....ipynb
.
Can you fix those paths issues? Thanks.
I have added the pip
dependency that mybinder
was "nagging" me about, but it looks weird. Check and let me know if you have a better option.
Also: We need to check why Travis
did not picked up those issues.
Many thanks @thast! I will get to this over the weekend. Does the overall |
I did not looked at |
👋 @thast: would you be willing to do another pass on this? I updated the links, so I believe it should be good to go unless you catch anything else. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @lheagy ! looks great!
Two comments:
- in
index.ipynb
, thecontact
link is broken and needs to be updated (see picture below) (fixed) - at the root of the repository, is the uppercase necessary for the
Notebooks
folder? (see picture below)
Thanks @thast! It looks like you fixed the broken link :) and the |
Follow the geosci-labs repository for maintaining the notebooks. The maintenance strategy now follows that outlined in geosci-course
.jupyter-include
file contains the list of notebooks that we copy-over from geosci-labsgeosci-labs
👋 @thast, would you be willing to review this?