-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tox and switch to GithubAction #97
Conversation
.github/workflows/ci.yml
Outdated
with: | ||
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
aws-region: us-east-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you need AWS credential to be able to use S3 file π€·ββοΈ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah should really use moto so we don't need to talk to S3 at all for tests
name: ${{ matrix.platform }}-${{ matrix.tox-env }} | ||
fail_ci_if_error: false | ||
|
||
# publish: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TDB
tox.ini
Outdated
deps= | ||
numpy | ||
passenv= | ||
AWS_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this if S3 credential is not needed
when trying to run the test within tox I get
π¬ |
@@ -14,8 +14,6 @@ | |||
"pytest-asyncio<0.11.0", | |||
"pytest-cov", | |||
"shapely", | |||
"botocore==1.15.32", | |||
"boto3==1.12.32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aioboto3, depends on aiobotocore which depends on specific boto3 and botocore versions. It's easier to let hem decide the version they need ;-)
tox.ini
Outdated
@@ -7,8 +7,6 @@ commands= | |||
python -m pytest --cov aiocogeo --cov-report xml --cov-report term-missing | |||
deps= | |||
numpy | |||
passenv= | |||
AWS_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed in fact!
I pulled down your changes, ran |
You might be able to merge this onto a non- |
Finished in #99 ! |
π This pr does:
To be discussed