Gracefully handle NULL numeric, date fields #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd date fields, like those produced by QGIS
This was referenced Dec 4, 2014
Closed
GeospatialPython
added a commit
that referenced
this pull request
Jan 9, 2015
Gracefully handle NULL numeric, date fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the DBase spec doesn't allow NULL values, QGIS allows one to write/edit a Shapefile with specially-encoded NULL values. It does this by writing full-width '*' characters for numeric types, and '0' characters for date types.
Pyshp blows up with a ValueError when parsing these NULL values. This patch gracefully handles these specially-encoded NULLs, and hands back None as a value, which is much more Pythonic than casting incorrectly to 0 or [0, 0, 0] respectively.
Also attached is a simple example Shapefile created by QGIS with NULL values.