Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typescript #9

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Use typescript #9

merged 4 commits into from
Feb 11, 2019

Conversation

hwbllmnn
Copy link
Contributor

Switches the library to use typescript.

@terrestris/devs Please review.

Copy link
Contributor

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the note regarding declaration.
Furthermore i think you can remove all the babel packages from the package.json.

index.d.ts Outdated Show resolved Hide resolved
@hwbllmnn
Copy link
Contributor Author

I also tried removing the babel packages, but some of them are still required, else the tests would not run. This might be related to jest 24 and/or babel 7, but I'm not sure, so I'm just leaving them in for now. The coverage does not work in this combination (which might be a result of ts-jest not having been tested with jest 24 as a warning notes).

@hwbllmnn hwbllmnn merged commit f3e02d3 into geostyler:master Feb 11, 2019
@hwbllmnn hwbllmnn deleted the use-typescript branch February 11, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants