Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support symbolizer visibility #723

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

miccoh1994
Copy link
Contributor

@miccoh1994 miccoh1994 commented Jun 5, 2023

Description

Add support for the symbolizer vibility field. Simply does not create a style if visibility is false.

Related issues or pull requests

geostyler/geostyler#1940

geostyler/geostyler#2155

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

Copy link
Contributor

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miccoh1994. Yet another nice addition. I just tweaked it a bit.

src/OlStyleParser.ts Outdated Show resolved Hide resolved
… undefined

Co-authored-by: Kai Volland <kaivolland@yahoo.de>
@KaiVolland KaiVolland merged commit c7206f5 into geostyler:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants