Fix types and remove unnecessary async #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done. |
|
Thanks, @constantinius |
|
@constantinius Did you mean to publish this as v2.0.2? Looks like npmjs.com does not have that package (yet). |
|
@ahocevar This should actually be included in 2.0.2 🤔 |
|
@ahocevar The github action has failed. Have restarted it and it passed now. Release should be up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that types are published, it is imporant that async functions have the correct
@returnstype, i.e. aPromise. Also, functions that are not async should not have theasynckeyword.This pull request fixes that.
It would be good if a patch release could be published when this is merged. This is the last showstopper for updating geotiff to v2 in OpenLayers. See openlayers/openlayers#13292.