remove the final modifier to ContentFeatureStore.addFeatures method. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContentFeatureStore.addFeatures works by grabbing a FeatureWriter from the concrete subclass, but it can be the case that that's not the best way of doing so for a given immplementation, so removing the final modifier from the method allows for further optimizations on the subclasses where appropriate while keeping the default behavior.
|
Looks ok to me. If there is a problem later easy enough to roll back. |
jdeolive
pushed a commit
that referenced
this pull request
Jan 25, 2013
remove the final modifier to ContentFeatureStore.addFeatures method.
piomar123
pushed a commit
to piomar123/geotools
that referenced
this pull request
Sep 17, 2021
…t-tests (geotools#115) * Bump jetty-server in /its/it-tests Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 9.4.35.v20201120 to 9.4.41.v20210516. - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](jetty/jetty.project@jetty-9.4.35.v20201120...jetty-9.4.41.v20210516) --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-server dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * build it Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukasz Jarocki <lukasz.jarocki@sonarsource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentFeatureStore.addFeatures works by grabbing a FeatureWriter from
the concrete subclass, but it can be the case that that's not the best
way of doing so for a given immplementation, so removing the final modifier
from the method allows for further optimizations on the subclasses where
appropriate while keeping the default behavior.