Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleCI publishing strategy #107

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Update CircleCI publishing strategy #107

merged 4 commits into from
Jun 13, 2019

Conversation

rbreslow
Copy link
Contributor

@rbreslow rbreslow commented Jun 12, 2019 •
edited
Loading

Overview

  • Add release/* and hotfix/* to branches filter to publish artifacts to SNAPSHOT repository so we can test after committing fixes.
  • Remove master from branches filter to stop publishing release artifacts twice (once for tags, and once for branches).

Resolves #105

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Testing Instructions

See: https://circleci.com/gh/geotrellis/maml/369

There isn't a great way to test the removal of master from the branches filter without pushing something to master.

@rbreslow rbreslow self-assigned this Jun 12, 2019
hectcastro
hectcastro approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@hectcastro hectcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rbreslow rbreslow merged commit ac794ce into develop Jun 13, 2019
@rbreslow rbreslow deleted the feature/jrb/update-circleci-publishing-strategy branch June 13, 2019 03:20
@rbreslow rbreslow removed the request for review from pomadchin June 13, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectcastro hectcastro hectcastro approved these changes

Assignees

@rbreslow rbreslow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CircleCI publishing strategy
2 participants
@rbreslow @hectcastro