Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog and pull request template #96

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Add changelog and pull request template #96

merged 3 commits into from
Apr 26, 2019

Conversation

rbreslow
Copy link
Contributor

@rbreslow rbreslow commented Apr 26, 2019 •
edited
Loading

Overview

This PR adds a change log (following keep a changelog principles) and a GitHub pull request template.

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

@rbreslow rbreslow self-assigned this Apr 26, 2019
hectcastro
hectcastro approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@hectcastro hectcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition of the PR template with CHANGELOG reminder. 👍

@rbreslow rbreslow merged commit 1e5e706 into develop Apr 26, 2019
@rbreslow rbreslow deleted the feature/jrb/add-changelog branch April 26, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectcastro hectcastro hectcastro approved these changes

Assignees

@rbreslow rbreslow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbreslow @hectcastro