Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose unloading function and only auto-unload inside components #67

Merged
merged 7 commits into from
Jan 19, 2022
Merged

feat: expose unloading function and only auto-unload inside components #67

merged 7 commits into from
Jan 19, 2022

Conversation

anbraten
Copy link
Contributor

@anbraten anbraten commented Jan 19, 2022 •
edited by lukashass
Loading

Closes #8

Off topic

  • Changes wording in test titles

@anbraten anbraten changed the title Update useFind.ts Improve loading & loading of composition Jan 19, 2022
@anbraten anbraten marked this pull request as ready for review January 19, 2022 15:24
@anbraten anbraten changed the title Improve loading & loading of composition feat: expose loading & unloading function and only auto unload inside components Jan 19, 2022
@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 100% 121/121
🟢 Branches 100% 38/38
🟢 Functions 100% 29/29
🟢 Lines 100% 173/173

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 96f6ef1

@lukashass
Copy link
Member

lukashass commented Jan 19, 2022 •
edited
Loading

When creating the merge commit message keep in mind that this is a breaking change.

  • removed disableUnloadingEventHandlers param (is there another way to force not unloading the event handlers?)

lukashass
lukashass requested changes Jan 19, 2022
View reviewed changes
test/useGet.test.ts Outdated Show resolved Hide resolved
src/useGet.ts Outdated Show resolved Hide resolved
src/useGet.ts Show resolved Hide resolved
@lukashass lukashass changed the title feat: expose loading & unloading function and only auto unload inside components feat: expose unloading function and only auto unload inside components Jan 19, 2022
@lukashass lukashass changed the title feat: expose unloading function and only auto unload inside components feat: expose unloading function and only auto-unload inside components Jan 19, 2022
@lukashass lukashass merged commit 8c7a56a into main Jan 19, 2022
@lukashass lukashass deleted the anbraten-patch-1 branch January 19, 2022 20:14
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukashass lukashass lukashass approved these changes

@raphaelschwinger raphaelschwinger Awaiting requested review from raphaelschwinger

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose unload function
2 participants
@anbraten @lukashass