prevent unknown or misspelled annotators from being added to the annotator-array #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardobort
requested changes
Apr 14, 2019
src/pipeline.js
Outdated
| if ( | ||
| Object.prototype.hasOwnProperty.call(ANNOTATORS_BY_KEY, annotatorKey) | ||
| ) { | ||
| acc.push(ANNOTATORS_BY_KEY[annotatorKey]); |
There was a problem hiding this comment.
I’d expect a pure function being passed as reducer. Instead of push you can return acc.concat([newelem]); (sorry the syntax, i’m With my phone) 🙃
src/pipeline.js
Outdated
| ) { | ||
| acc.push(ANNOTATORS_BY_KEY[annotatorKey]); | ||
| } else { | ||
| console.log(`Annotator "${annotatorKey}" doesn't exist or is not supported. Removing it from the pipeline.`); |
There was a problem hiding this comment.
I don’t remember if I used console before, maybe throwing an error instead? It should not just warn you in that case, it should stop the execution as is a misconfiguration based on this wrapper limitations.
|
Thanks for the quick feedback. Sounds absolutely reasonable! :) |
gerardobort
pushed a commit
that referenced
this pull request
Apr 15, 2019
…dded to the annotator-array (#49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for creating this wrapper! I like it a lot. :)
When I recently tried to use it with the "openie" annotator the program threw an unhandled exception. It seems like Annotators that are valid for CoreNLP but non-existend in ANNOTATORS_BY_KEY will add an undefined element to the annotator-list, causing problems down the line.
To reproduce, just add openie to the list of annotators.
I added a check to prevent that and added logging for the user.
This is my first pull request, so please let me know if you spot any mistakes I've made.