Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and new features #107

Merged
merged 6 commits into from
Jan 13, 2021
Merged

Bug fix and new features #107

merged 6 commits into from
Jan 13, 2021

Conversation

apcamargo
Copy link
Contributor

@apcamargo apcamargo commented May 31, 2020

I know that opening a PR with multiple unrelated fixes and new functions isn't ideal, but I've been working with this slightly modified version of enrichM and I decided to share my fixes and additions.

This PR does the following:

@apcamargo apcamargo changed the title Fix some bugs and split Pfam and TIGRFAM HMM cutoffs into separate arguments Bug fix and new features Jun 4, 2020
@geronimp
Copy link
Owner

Hey,

I really appreciate these additions, thanks for those bug fixes. I've just merged them in (some time later).

@geronimp geronimp merged commit 45d5d81 into geronimp:master Jan 13, 2021
@apcamargo
Copy link
Contributor Author

Thanks, @geronimp!

Another think that I did was to update all the databases (and their respetive pickles) to their latest versions. If you are interested, I can make those files available to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants