Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_pkgrefs("DESCRIPTION") and export_description(rang) #113

Open
chainsawriot opened this issue Mar 14, 2023 · 3 comments
Open

as_pkgrefs("DESCRIPTION") and export_description(rang) #113

chainsawriot opened this issue Mar 14, 2023 · 3 comments

Comments

@chainsawriot
Copy link
Collaborator

Again, we have all the ingredients. The good things about this is that as_pkgs can look for Remotes for possible Github packages.

For export_description, we can dump x=handle@uid (Github package) in the Remotes field of the DESCRITION file.

@schochastics
Copy link
Member

@chainsawriot I can tackle this one though I am not sure I understand the purpose of it. Is it supposed to read and write package DESCRIPTIONS? or create specific DESCRIPTION files for compendia?

@chainsawriot chainsawriot changed the title as_pkgs("DESCRIPTION") and export_description(rang) as_pkgrefs("DESCRIPTION") and export_description(rang) Mar 24, 2023
@chainsawriot
Copy link
Collaborator Author

@schochastics

Is it supposed to read and write package DESCRIPTIONS? or create specific DESCRIPTION files for compendia?

I think we can think about as_pkgrefs("DESCRIPTION") first, because for reading we can think about them (package DESCRIPTION and compendium DESCRIPTION, e.g. from rrtools) the same way.

One reference of behavior is dockta.

For example this DESCRIPTION file

https://github.com/chainsawriot/mzesalike/blob/master/DESCRIPTION

should give: cran::leaflet, github::yihui/xaringan, github::chainsawriot/xaringanExtra, github::chainsawriot/xaringanExtra. If there is a Date field, we can use it as snapshot_date.

I'm still thinking about how export_description should behave. We can either write the entire installation_order (like export_renv) or just the initial queried pkgrefs (that would be like dockta).

@schochastics
Copy link
Member

Ok I will start working on as_pkgrefs("DESCRIPTION") for now

chainsawriot added a commit that referenced this issue Mar 27, 2023
chainsawriot added a commit that referenced this issue Mar 29, 2023
Add implementation of `as_pkgrefs("DESCRIPTION")` #113
@chainsawriot chainsawriot removed the v0.3 label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants