Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed dockerization due to missing VignetteBuilder #99

Closed
chainsawriot opened this issue Feb 28, 2023 · 4 comments
Closed

Failed dockerization due to missing VignetteBuilder #99

chainsawriot opened this issue Feb 28, 2023 · 4 comments
Assignees
@chainsawriot
Labels
bug Something isn't working

Comments

@chainsawriot
Copy link
Collaborator

The example is the package

graph <- resolve("github::chainsawriot/rang", "2023-02-27")
dockerize(graph, "~/dev/misc/localdocker", cache = TRUE)

When building, it failed due to missing knitr.

I am investigating whether CRAN has the same issue.
@chainsawriot chainsawriot added the bug Something isn't working label Feb 28, 2023
@chainsawriot
Copy link
Collaborator Author

CRAN and bioc do not have the same issue because the Vignette(s) have been built inside the tarball.

A quick solution to this is to consider Vignette Builder for GitHub (and local)...

https://github.com/chainsawriot/rang/blob/5a313175fe589b1b09d035c7f8cad42757b2695f/R/resolve.R#L120

@chainsawriot chainsawriot self-assigned this Feb 28, 2023
@chainsawriot
Copy link
Collaborator Author

#49 is important to find out this kind of bugs. Currently, these bugs are found the hard way.

@chainsawriot
Copy link
Collaborator Author

Adding knitr when VignetteBuilder is available isn't enough. It also needs rmarkdown.

@chainsawriot
Copy link
Collaborator Author

Need to investigate why R CMD --no-vignettes doesn't work

chainsawriot added a commit that referenced this issue Feb 28, 2023
@chainsawriot
Make compiling raw packages with --no-build-vignettes #99
2c8fd0f 
But still need to dig when this option was changed from
`--no-vignettes` to `--no-build-vignettes`
chainsawriot added a commit that referenced this issue Feb 28, 2023
@chainsawriot
Merge pull request #100 from chainsawriot/extractvig
6af57a2 
Make compiling raw packages with `--no-build-vignettes` #99
chainsawriot added a commit that referenced this issue Feb 28, 2023
@chainsawriot
add initial support for dockerize local packages
3e2b6bf 
but found #99
@chainsawriot chainsawriot mentioned this issue Feb 28, 2023
Open
chainsawriot added a commit that referenced this issue Mar 5, 2023
@chainsawriot
fix #99 for non-cached github packages
6c0bd2c 
Also simplify the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chainsawriot chainsawriot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chainsawriot