Failure with dev haven

[hadley]

checking examples ... ERROR
Running examples in ‘rio-Ex.R’ failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: convert
> ### Title: Convert from one file format to another
> ### Aliases: convert
> 
> ### ** Examples
> 
> # create a file to convert
> export(iris, "iris.dta")
Error: The following variable names are not valid Stata variables: `Sepal.Length`, `Sepal.Width`, `Petal.Length`, `Petal.Width`
Execution halted

checking tests ... ERROR
Running the tests in ‘tests/test-all.R’ failed.
Last 13 lines of output:
  3: as.expectation(exp, ..., srcref = srcref) at /private/tmp/RtmpQjBlGo/devtoolscfb138fb2e0/hadley-testthat-46d15da/R/expectation.R:33
  4: identical(as.vector(object), TRUE) at /private/tmp/RtmpQjBlGo/devtoolscfb138fb2e0/hadley-testthat-46d15da/R/expectation.R:112
  5: as.vector(object)
  6: is.data.frame(import("http://www.stata-press.com/data/r13/auto.dta"))
  7: import("http://www.stata-press.com/data/r13/auto.dta")
  8: .import(file = file, ...)
  9: .import.rio_dta(file = file, ...)
  10: convert_attributes(read_dta(path = file))
  11: read_dta(path = file)

  DONE ===========================================================================
  Error: Test failures
  Execution halted

checking re-building of vignette outputs ... WARNING
Error in re-building vignettes:
  ...
Quitting from lines 56-62 (rio.Rmd) 
Error: processing vignette 'rio.Rmd' failed with diagnostics:
The following variable names are not valid Stata variables: `Sepal.Length`, `Sepal.Width`, `Petal.Length`, `Petal.Width`
Execution halted


checking R code for possible problems ... NOTE
.import.rio_dta: possible error in read_dta(path = file): unused
  argument (path = file)
.import.rio_sav: possible error in read_sav(path = file): unused
  argument (path = file)

Because we're now more careful about valid stata var names.

[leeper]

@hadley I've fixed this in the current dev version of rio, but because of the changes you've made to the names of formal arguments (path -> file), the current version of rio on CRAN will break when you release but this version will break if I release rio before you release haven. Perhaps we can coordinate on timing so as not to annoy the CRAN people too much?

[hadley]

Sure, that's fine with me - I'll probably do the usual two week notification once I pick an actual release date, and then you'll get another notification the day of submission (and I'll add a note in my cran-comments). Does that work for you?

[leeper]

@hadley Sounds perfect. Thanks!