Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trust also for import_list() ref #406 #417

Merged
merged 4 commits into from
May 16, 2024
Merged

Add trust also for import_list() ref #406 #417

merged 4 commits into from
May 16, 2024

Conversation

chainsawriot
Copy link
Collaborator

No description provided.

@chainsawriot chainsawriot marked this pull request as ready for review May 16, 2024 11:58
jsonbecker
jsonbecker approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@jsonbecker jsonbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jsonbecker
Copy link
Collaborator

An alternative could be to call import() internal to import_list. It seems a bit strange to reimplement load directly here.

@chainsawriot
Copy link
Collaborator Author

@jsonbecker Good suggestion. The import method needs a little modification. But now it works and has less redundant code.

@chainsawriot chainsawriot merged commit 0310e20 into main May 16, 2024
9 checks passed
@chainsawriot chainsawriot deleted the import_list_trust branch May 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsonbecker jsonbecker jsonbecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chainsawriot @jsonbecker