Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dictionary-like conditions #210

Closed
wooorm opened this issue Oct 1, 2018 · 9 comments
Closed

Add support for dictionary-like conditions #210

wooorm opened this issue Oct 1, 2018 · 9 comments
Labels
good first issue 👋 This may be a great place to get started! hacktoberfest

Comments

@wooorm
Copy link
Member

wooorm commented Oct 1, 2018

Subject of the issue

retext-equality and retext-profanities messages are pretty polarising, and expect the worst of the writer. We should add something of a conditional in messages.

Steps to reproduce

For example:

The girl had black hair, black nail polish, and black skin.

Expected behaviour

It could yield:

1:5-1:9 Be careful with girl, when referring to a person, it’s profane in some cases
1:5-1:9 `girl` may be insensitive, when referring to a person, use `kid`, `child` instead
1:14-1:19 Reconsider using black, to refer to an individual or a skin tone, it may be profane
...

Actual behaviour

Yields:

1:5-1:9 Be careful with girl, it’s profane in some cases
1:5-1:9 `girl` may be insensitive, use `kid`, `child` instead
1:14-1:19 Reconsider using black, it may be profane
...

Proposed solution

In retext-equality, wou could add a condition field next to considerate and inconsiderate.
Along the lines of condition: to refer to an individual or a skin tone.
And pick that up in the messaging.

Supersedes GH-196.

@wooorm
Copy link
Member Author

wooorm commented Oct 1, 2018

Also related to GH-72.

@wooorm wooorm added hacktoberfest good first issue 👋 This may be a great place to get started! labels Oct 1, 2018
@wooorm
Copy link
Member Author

wooorm commented Oct 1, 2018

Note also that this is a pretty big issue, it’ll require many conditions to the original files!

@jonyeezs
Copy link

jonyeezs commented Oct 6, 2018

Is there a way we could split this issues into multiples TODOs that can be tackled individually?

@wooorm
Copy link
Member Author

wooorm commented Oct 7, 2018

@jonyeezs Hmm, it can be split up by first doing one initial condition, and writing the code for that, and then slowly porting the rest of retext-equality over? 🤔

@wooorm
Copy link
Member Author

wooorm commented Oct 7, 2018

Would you like prefer issues for that?

@jonyeezs
Copy link

jonyeezs commented Oct 7, 2018

yeah slowly porting over seems less overwhelming.

I guess i may have posted a silly statement. As someone new to this project, I'm not sure what I'm dealing with.

But I love the mission of what alex is and would love to contribute.

Side-note: This is inspiring me to create a chrome extension! But that would be for another future date XD

@wooorm
Copy link
Member Author

wooorm commented Oct 7, 2018

@jonyeezs Oh don’t worry about it, it’s not silly at all :) I’m sure other people have the same question, thanks for asking it.

yeah slowly porting over seems less overwhelming.

would you be able and are you interested to work on the first condition and the initial code?

Side-note: This is inspiring me to create a chrome extension! But that would be for another future date XD

Please do! It’s also not easy, probably hard, though. Some people have tried but never finished it!

And thanks for your lovely comments about alex, I appreciate it 🤗

@brycekahle
Copy link

@wooorm I made an attempt on the code side of things in retext-equality. See retextjs/retext-equality#55

Murderlon pushed a commit to retextjs/retext-equality that referenced this issue Oct 9, 2018
@Murderlon
Copy link
Member

Resolved in retextjs/retext-equality#55

riley-martine pushed a commit to riley-martine/retext-equality that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 👋 This may be a great place to get started! hacktoberfest
Development

No branches or pull requests

4 participants