-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom formatters #308
Conversation
This comment has been minimized.
This comment has been minimized.
Hi there! unified also allows custom formatters, and this is built into the code we’re using: see engine options the reporter and reporterOptions. I’m fine with adding this but don’t see why we shouldn’t use what’s build in already |
Hi @wooorm, it makes a lot more sense doing it that way! I've changed it to use vfile reporters like unified does, which works and the CI passes (2nd to last commit). However, when I tried to use
this is from the latest commit in this branch. any advice would be appreciated thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
The out
removal is probably causing the error.
And some other tips inline!
thanks for the help @wooorm, I've made the changes you suggested, and all tests are passing again |
thanks @k-yle, released! |
This PR adds support for custom formatters instead of
vfile-reporter
, like what eslint does.Use case: you want machine-readable output to integrate with other CI tooling, such as the Gitlab CI .