Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove eventstore.Subscriber support #42

Merged
merged 5 commits into from
Aug 24, 2021
Merged

feat: remove eventstore.Subscriber support #42

merged 5 commits into from
Aug 24, 2021

Conversation

ar3s3ru
Copy link
Collaborator

@ar3s3ru ar3s3ru commented Aug 24, 2021

Partially addresses #37.

  • feat(eventstore): remove Subscriber interface
  • chore(subscription): disable Volatile subscription
  • refactor(subscription): remove old CatchUp and rename PullCatchUp to CatchUp
  • chore: remove aggregate.RepositoryEventStore interface

@ar3s3ru ar3s3ru enabled auto-merge (squash) August 24, 2021 21:59
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.8% 82.8% Coverage
0.0% 0.0% Duplication

@ar3s3ru ar3s3ru merged commit 87376e5 into main Aug 24, 2021
@ar3s3ru ar3s3ru deleted the remove-subscriber-support branch August 24, 2021 21:59
@ar3s3ru ar3s3ru linked an issue Aug 24, 2021 that may be closed by this pull request
refactor: remove Subscriber interface #37
Closed
@ar3s3ru ar3s3ru mentioned this pull request Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: remove Subscriber interface
1 participant
@ar3s3ru