Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed word boundary tests on paths #93

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fixed word boundary tests on paths #93

merged 1 commit into from
Jul 7, 2021

Conversation

cognitivegears
Copy link
Contributor

@cognitivegears cognitivegears commented Jul 2, 2021

Please check if the PR fulfills these requirements

  • [ X ] The commit message follows our guidelines
  • [ X ] Tests for the changes have been added (for bug fixes / features)
  • [ N/A ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
Currently, the boundary option is not respected when testing file paths. This is due to a difference between the matching code used for testing normal text and paths.

What is the new behavior (if this is a feature change)?
Changed the functionality to respect word boundaries, matching the functionality of line tests.

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
Only if a consumer of the tool expects files name matching and content matching to differ for word boundaries, probably unlikely.

Other information:
N/A

Fixes #94

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #93 (7c794de) into main (f86ffb4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          21       21           
  Lines         478      478           
=======================================
  Hits          457      457           
  Misses         12       12           
  Partials        9        9           
Impacted Files Coverage Δ
pkg/result/pathresult.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86ffb4...7c794de. Read the comment docs.

@caitlinelfring caitlinelfring merged commit 4c7f232 into get-woke:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Woke fails to work with word boundary on file names
2 participants