Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split NWC client and webln provider #182

Closed
bumi opened this issue Jan 8, 2024 · 1 comment · Fixed by #197
Closed

Split NWC client and webln provider #182

bumi opened this issue Jan 8, 2024 · 1 comment · Fixed by #197
Assignees

Comments

@bumi
Copy link
Contributor

bumi commented Jan 8, 2024

NWC and webln are not fully compatible.
currently our NWC client is webln compatible which limits us using some NWC details

We should split this up
and make a NWC client independent of WebLN.

Maybe we make a NWC class and the NWC webln provider inherits from that one?

@rolznz
Copy link
Contributor

rolznz commented Jan 8, 2024

Or @bumi 's other suggestion:

maybe have a NWC client and a NWC WebLN Provider uses that and returns the webln required data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants