Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag page with existing tag by mouse-click not working #16

Closed
orjhor opened this issue Mar 11, 2015 · 20 comments
Closed

Tag page with existing tag by mouse-click not working #16

orjhor opened this issue Mar 11, 2015 · 20 comments

Comments

@orjhor
Copy link

orjhor commented Mar 11, 2015

When tagging a page with an existing tag by clicking the tag, EPiServer is not registering the textbox as changed, thus not saving the tag-property on "Save & publish".
This does not seem to be an issue if you are creating a new tag.

However, selecting the existing tag by using the up/down keys + Enter will trigger the textbox changed.

Tried with latest vanilla Alloy site and latest Geta.Tags version.

@frederikvig
Copy link
Member

Which version of EPiServer did you test this on?

@orjhor
Copy link
Author

orjhor commented Mar 25, 2015

I've had this problem since 7.19.1, but also in the later updates. I tested it today on the latest version (update 58) also. The issue is not consistent, as you can see in my attached .gif.
demo

@frederikvig
Copy link
Member

I tried reproducing this on a fresh Alloy site (EPiServer - update 58) without success (using Chrome). I think this might be browser related - have you had similar problems with the built in properties before?

@orjhor
Copy link
Author

orjhor commented Mar 27, 2015

I've tried IE 11 and Chrome (latest version, 41.0.2272.101).
I tried a fresh Alloy (with the latest update 58 Visual Studio template) also, with the exact same result. Also tried both WebForms and MVC just to rule that out, but with the same result.

This is me testing the latest Geta.Tags in a fresh Visual Studio Alloy-template running update 58 in Chrome:
link to gif

@marisks
Copy link
Member

marisks commented Mar 27, 2015

I could reproduce that behavior in Chrome. Can check next week for solution.

@marisks
Copy link
Member

marisks commented Apr 23, 2015

Tried to solve it, but without any results. For some reason EPiServer time to time do not trigger change event. As this issue occurs only in some specific scenarios, I will not do more investigation, but we are open for contributions if solution found.

@robgha01
Copy link

We have the same problem, but only on the live site with the same webbrowser "Chrome" however
it works in our local environment.

I tested with fiddler and no property changed request happens live the only requests that is made is "/getatags?term=te".

I installed the live site localy and managed to reproduce the issue. No indication on what the main problem is. One console message i get in the browser is "Discovery] It looks like there was a problem: Error: Not enough data {stack: (...), message: "Not enough data"}message: "Not enough data"stack: (...)get stack: function () { [native code] }set stack: function () { [native code] }proto: d" dont know if it is related to the problem i only get that message when geta stops working (wont trigger save event).

Could not find anyting more to this problem, im giving up xD

@timker
Copy link

timker commented Sep 21, 2015

I'm also having with this issue this.
One workaround is to add a pointless tag and then remove it.

tested on
geta tags 1.0.4 and 2.0.3.0
EPiServer 7.19 and 8.8.0.0 Alloy
Chrome (45) & Firefox on a PC

@ezsearch
Copy link

I can confirm the same. I am using the latest 2.4.1. The text box change trigger is not getting fired.

@marisks
Copy link
Member

marisks commented Apr 12, 2016

Fixed by: #34

@marisks marisks closed this as completed Apr 12, 2016
@jonizen
Copy link

jonizen commented Apr 19, 2016

I can still recreate this issue. It seems to me that the problem occurs when you use the auto-complete to use an already existing tag and select it with the mouse. If you dont click in the tags container before clicking outside it, the change is not triggered. I also think if the auto-save occurs before you click in the tags container then tags save null. Just a thought :)

@marisks
Copy link
Member

marisks commented Apr 19, 2016

@jonizen do you use latest version (2.1.9)? Also did you try to clear browser cache?

In latest version, save gets triggered on item selection from auto-complete list.

@jonizen
Copy link

jonizen commented Apr 20, 2016

Yes, both. I can se your changes in #34 in my ClientResources. I tried on two different sites. To be clear, EPi should detect the change when i click (with the mouse) on an existing tag?

animation1
click-in-textbox-after-selection
on-enter-click

I attached 3 gifs.
First with the issue i am having. (i then click outside the textarea)
Second show if we click somewhere in the textbox the change is triggered (i then click outside the textarea)
And the third when hitting enter it works.

@marisks
Copy link
Member

marisks commented Apr 20, 2016

@jonizen Could you check in browser's developer tools how Geta.Tags/TagsSelection.js script under ClienResources looks like?
From gifs I see that this is old behavior before changes.

@joseftw
Copy link
Contributor

joseftw commented Apr 20, 2016

Hey, we are working on the same project...it looks like this
snip_20160420090653

The problem occurs for me as well

@marisks
Copy link
Member

marisks commented Apr 20, 2016

@joseftw it looks like the right version. Which EPiserver version do you have? Do you have any errors in browser console?

@marisks marisks reopened this Apr 20, 2016
@joseftw
Copy link
Contributor

joseftw commented Apr 20, 2016

We are currently using
EPiServer.CMS.Core 9.0.3
EPiServer.CMS.UI 9.0.0
EPiServer.CMS.UI.Core 9.0.0
EPiServer.Framework 9.0.3

Do you think the problem will go away if we upgrade to the latest version of EPI?

@marisks
Copy link
Member

marisks commented Apr 20, 2016

It works on my site with:
EPiServer.CMS.Core 9.6.1
EPiServer.CMS.UI 9.3.8
EPiServer.CMS.UI.Core 9.3.8
EPiServer.Framework 9.6.1

I am not sure if upgrade helps, but you could try - upgrade is needed anyway :)

@jonizen
Copy link

jonizen commented Apr 20, 2016

I upgraded the site from:
EPiServer.CMS.Core 9.0.3
EPiServer.CMS.UI 9.0.0
EPiServer.CMS.UI.Core 9.0.0
EPiServer.Framework 9.0.3

To:
EPiServer.CMS.Core 9.8.1
EPiServer.CMS.UI 9.4.4
EPiServer.CMS.UI.Core 9.4.4
EPiServer.Framework 9.8.1

And it works perfectly! So a higher version of UI and the problem is gone. Thank you for all the help and quick replies!

@marisks
Copy link
Member

marisks commented Apr 20, 2016

That's great. I will close an issue as it works in latest versions.

@marisks marisks closed this as completed Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants