-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag page with existing tag by mouse-click not working #16
Comments
Which version of EPiServer did you test this on? |
I tried reproducing this on a fresh Alloy site (EPiServer - update 58) without success (using Chrome). I think this might be browser related - have you had similar problems with the built in properties before? |
I've tried IE 11 and Chrome (latest version, 41.0.2272.101). This is me testing the latest Geta.Tags in a fresh Visual Studio Alloy-template running update 58 in Chrome: |
I could reproduce that behavior in Chrome. Can check next week for solution. |
Tried to solve it, but without any results. For some reason EPiServer time to time do not trigger change event. As this issue occurs only in some specific scenarios, I will not do more investigation, but we are open for contributions if solution found. |
We have the same problem, but only on the live site with the same webbrowser "Chrome" however I tested with fiddler and no property changed request happens live the only requests that is made is "/getatags?term=te". I installed the live site localy and managed to reproduce the issue. No indication on what the main problem is. One console message i get in the browser is "Discovery] It looks like there was a problem: Error: Not enough data {stack: (...), message: "Not enough data"}message: "Not enough data"stack: (...)get stack: function () { [native code] }set stack: function () { [native code] }proto: d" dont know if it is related to the problem i only get that message when geta stops working (wont trigger save event). Could not find anyting more to this problem, im giving up xD |
I'm also having with this issue this. tested on |
I can confirm the same. I am using the latest 2.4.1. The text box change trigger is not getting fired. |
Fixed by: #34 |
I can still recreate this issue. It seems to me that the problem occurs when you use the auto-complete to use an already existing tag and select it with the mouse. If you dont click in the tags container before clicking outside it, the change is not triggered. I also think if the auto-save occurs before you click in the tags container then tags save null. Just a thought :) |
@jonizen do you use latest version (2.1.9)? Also did you try to clear browser cache? In latest version, save gets triggered on item selection from auto-complete list. |
Yes, both. I can se your changes in #34 in my ClientResources. I tried on two different sites. To be clear, EPi should detect the change when i click (with the mouse) on an existing tag? I attached 3 gifs. |
@jonizen Could you check in browser's developer tools how Geta.Tags/TagsSelection.js script under ClienResources looks like? |
@joseftw it looks like the right version. Which EPiserver version do you have? Do you have any errors in browser console? |
We are currently using Do you think the problem will go away if we upgrade to the latest version of EPI? |
It works on my site with: I am not sure if upgrade helps, but you could try - upgrade is needed anyway :) |
I upgraded the site from: To: And it works perfectly! So a higher version of UI and the problem is gone. Thank you for all the help and quick replies! |
That's great. I will close an issue as it works in latest versions. |
When tagging a page with an existing tag by clicking the tag, EPiServer is not registering the textbox as changed, thus not saving the tag-property on "Save & publish".
This does not seem to be an issue if you are creating a new tag.
However, selecting the existing tag by using the up/down keys + Enter will trigger the textbox changed.
Tried with latest vanilla Alloy site and latest Geta.Tags version.
The text was updated successfully, but these errors were encountered: