Fix the incorrect message name in messages.proto #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While generate the messages.proto , the message name of the return value for smart contract's constant function is incorrect. For example , if a smart contract has a `getBalance` function which return a string , it will generate an unexpected `GetBalanceReq` message instead of generating `GetBalanceResp` message in the messages.proto.
quesalltime
changed the title
alanchchen
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generate the messages.proto , the message name of the return value for smart contract's constant function is incorrect.
For example ,
if a smart contract has a
getNamefunction which return a string ,it will generate an unexpected
GetNameReqmessage instead of generatingGetNameRespmessage in the messages.proto.