Don't read the servlet's InputStream #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote recording should be enabled when appmap.recording.requests is false.
apotterri
force-pushed
the
empty-input_20230822
branch
from
dbd72ae
to
1e19e09
Compare
Don't run the spring-javaformat plugin in the PetClinic apps. Also, make the test scripts a little less chatty.
When a SpringApplication is deployed to a servlet container (e.g. Tomcat), both the SpringApplication.applyInitializers and SpringServletContainerInitializer.onStartup will be run. These changes allow for that, and ensure that the ServletListener and RemoteRecordingFilter are only added once.
The agent should not cause the body of a request to be read, e.g. by getting the parameter map before HttpServlet.service is invoked. These changes avoid this by calling getParameterMap after HttpServlet.service returns.
apotterri
force-pushed
the
empty-input_20230822
branch
from
1e19e09
to
536b217
Compare
dustinbyrne
approved these changes
Sep 1, 2023
|
🎉 This PR is included in version 1.20.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent should not cause the body of a request to be read, e.g. by
getting the parameter map before HttpServlet.service is invoked. These
changes avoid this by calling getParameterMap after HttpServlet.service
returns.
Also fixes a couple of other bugs I noticed while working on this one.
Fixes #199 .