fix: Truncate largest message if max tokens are exceeded #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinbyrne
force-pushed
the
feat/truncate-token-input
branch
2 times, most recently
from
ed7b0d4
to
a71bf3b
Compare
kgilpin
reviewed
Sep 21, 2024
There was a problem hiding this comment.
@dustinbyrne can you add a Navie review, just looking for potential problems with the error handing and retry logic? Will the @review command do this?
|
@dustinbyrne please verify whether this Error is being reported -- https://github.com/getappmap/navie-benchmark/actions/runs/10974016842/job/30472143812#step:7:789 I did try and incorporate your fix into this branch -- https://github.com/getappmap/navie-benchmark/pull/62/commits/bdb33b06fa2a4111ed230f3657dc3a6b7a6fce9c |
dustinbyrne
force-pushed
the
feat/truncate-token-input
branch
from
e87649b
to
ac07acc
Compare
Upon exceeding the max token limit, the completion will be retried, where the largest message is truncated by 15% of the total content length.
dustinbyrne
force-pushed
the
feat/truncate-token-input
branch
from
ac07acc
to
0fdd7ab
Compare
|
🎉 This PR is included in version @appland/navie-v1.30.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon exceeding the max token limit, the completion will be retried, where the largest user message will be truncated by 15% of the total content length.
Resolves #2007